HomePhabricator

CrashHandler: be careful about crashing while handling

Authored by jfb on Jul 25 2019, 9:07 AM.

Description

CrashHandler: be careful about crashing while handling

Summary:
Looking at the current Apple-specific code for crash handling it does a few
silly things that I think we should avoid while handling crashes:

  • Try real hard not to allocate.
  • Set the global crash reporter string early so that any crash while generating the stack trace will still report some info.
  • Prevent reordering of operations in the current thread.

rdar://problem/53503334

Subscribers: hiraditya, jkorous, dexonsmith, llvm-commits, beanz, Bigcheese, thakis, lattner, jordan_rose

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65235

llvm-svn: 367031

Details

Committed
jfbJul 25 2019, 9:07 AM
Differential Revision
D65235: CrashHandler: be careful about crashing while handling
Parents
rGd8efec97bebd: [BPF] fix CO-RE incorrect index access string
Branches
Unknown
Tags
Unknown