HomePhabricator

Revert "hack to unbreak check-llvm on win after D97335" in attempt for actual…

Authored by sgraenitz on Mar 3 2021, 1:29 PM.

Description

Revert "hack to unbreak check-llvm on win after D97335" in attempt for actual fix

This reverts commit 900f076113302e26e1939541b546b0075e3e9721 and attempts an actual fix: All failing tests for llvm-jitlink use the -noexec flag. The inputs they operate on are not meant for execution on the host system. Looking e.g. at the MachO_test_harness_harnesss.s test, llvm-mc generates input machine code with "x86_64-apple-macosx10.9".

My previous attempt in bbdb4c8c9bcef0e8db751630accc04ad874f54e7 disabled the debug support plugin for Windows targets, but what we would actually want is to disable it on Windows HOSTS.

With the new patch here, I don't do exactly that, but instead follow the approach for the EH frame plugin and include the -noexec flag in the condition. It should have the desired effect when it comes to the test suite. It appears a little workaround'ish, but should work reliably for now. I will discuss the issue with Lang and see if we can do better. Thanks @thakis again for the temporary fix.

Event Timeline

This fixes the symbol lookup issue on Windows that was discussed post-review in D97339. Sorry for the inconvenience.

I'm not an expert in this field but this patch fixes my issue with the build on Windows.