HomePhabricator

[scudo] Don't track free/use stats for transfer batches.

Authored by hctim on May 3 2021, 10:42 AM.

Description

[scudo] Don't track free/use stats for transfer batches.

The Scudo C unit tests are currently non-hermetic. In particular, adding
or removing a transfer batch is a global state of the allocator that
persists between tests. This can cause flakiness in
ScudoWrappersCTest.MallInfo, because the creation or teardown of a batch
causes mallinfo's uordblks or fordblks to move up or down by the size of
a transfer batch on malloc/free.

It's my opinion that uordblks and fordblks should track the statistics
related to the user's malloc() and free() usage, and not the state of
the internal allocator structures. Thus, excluding the transfer batches
from stat collection does the trick and makes these tests pass.

Repro instructions of the bug:

  1. ninja ./projects/compiler-rt/lib/scudo/standalone/tests/ScudoCUnitTest-x86_64-Test
  2. ./projects/compiler-rt/lib/scudo/standalone/tests/ScudoCUnitTest-x86_64-Test --gtest_filter=ScudoWrappersCTest.MallInfo

Reviewed By: cryptoad

Differential Revision: https://reviews.llvm.org/D101653

Details

Committed
hctimMay 3 2021, 11:50 AM
Reviewer
cryptoad
Differential Revision
D101653: [scudo] Don't track free/use stats for transfer batches.
Parents
rG39bbfb77264a: [libc++] Use the internal Lit shell to run the tests
Branches
Unknown
Tags
Unknown