HomePhabricator

[ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)
e77442fa315bUnpublished

Authored by shafik on Apr 23 2020, 3:16 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

In ImportContext(…) we may call into CompleteDecl(…) which if FromRecrord is not
defined will start the definition of a ToRecord but from what I can tell at least
one of the paths though here don't ensure we complete the definition.
For a RecordDecl this can be problematic since this means we won’t import base
classes and we won’t have any of the methods or types we inherit from these bases.

Differential Revision: https://reviews.llvm.org/D78000

(cherry picked from commit def7c7f6020530ef2deb64f786d28775b5d0e47f)

Details