HomePhabricator

Resubmit: [AMDGPU] Invert the handling of skip insertion.

Authored by cdevadas on Jan 21 2020, 8:07 PM.

Description

Resubmit: [AMDGPU] Invert the handling of skip insertion.

The current implementation of skip insertion (SIInsertSkip) makes it a
mandatory pass required for correctness. Initially, the idea was to
have an optional pass. This patch inserts the s_cbranch_execz upfront
during SILowerControlFlow to skip over the sections of code when no
lanes are active. Later, SIRemoveShortExecBranches removes the skips
for short branches, unless there is a sideeffect and the skip branch is
really necessary.

This new pass will replace the handling of skip insertion in the
existing SIInsertSkip Pass.

Differential revision: https://reviews.llvm.org/D68092

Details

Committed
critsonJan 21 2020, 8:18 PM
Differential Revision
D68092: [AMDGPU] Invert the handling of skip insertion.
Parents
rGe0a6093a744d: [ORC] Fix a missing move in ce2207abaf9.
Branches
Unknown
Tags
Unknown