HomePhabricator

[lldb] Group ABI plugins

Authored by labath on Sat, Feb 1, 11:48 PM.

Description

[lldb] Group ABI plugins

Summary:
There's a fair amount of code duplication between the different ABI plugins for
the same architecture (e.g. ABIMacOSX_arm & ABISysV_arm). Deduplicating this
code is not very easy at the moment because there is no good place where to put
the common code.

Instead of creating more plugins, this patch reduces their number by grouping
similar plugins into a single folder/plugin. This makes it easy to extract
common code to a (e.g.) base class, which can then live in the same folder.

The grouping is done based on the underlying llvm target for that architecture,
because the plugins already require this for their operation.

Reviewers: JDevlieghere, jasonmolenda, jfb

Subscribers: sdardis, nemanjai, mgorny, kristof.beyls, fedor.sergeev, kbarton, jrtc27, atanasyan, jsji, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74138

Details

Committed
labathFri, Feb 7, 9:51 AM
Differential Revision
D74138: [lldb] Group ABI plugins
Parents
rG2e005c64f301: [lldb/test] Skip the AssertFrameRecognizer test for Linux
Branches
Unknown
Tags
Unknown