HomePhabricator

[AMDGPU] Limit runs of fixLdsBranchVmemWARHazard

Authored by piotr on Jun 14 2021, 3:17 AM.

Description

[AMDGPU] Limit runs of fixLdsBranchVmemWARHazard

The code in fixLdsBranchVmemWARHazard looks for patterns of a vmem/lds
access followed by a branch, followed by an lds/vmem access.

The handling of the hazard requires an arbitrary number of instructions
to process. In the worst case where a function has a vmem access, but no lds
accesses, all instructions are examined only to conclude that the hazard
cannot occur.

Add the pre-processing stage which detects if there is both lds and vmem
present in the function and only then does the more costly search.

This patch significantly improves compilation time in the cases the hazard
cannot happen. In one pathological case I looked at IsHazardInst is needlesly
called 88.6 milions times.

The numbers could also be improved by introducing a map around the
inner calls to ::getWaitStatesSince in fixLdsBranchVmemWARHazard, but
nothing will beat not running fixLdsBranchVmemWARHazard at all in the cases
detected by shouldRunLdsBranchVmemWARHazardFixup().

Differential Revision: https://reviews.llvm.org/D104219

Details

Committed
piotrJun 14 2021, 1:30 PM
Differential Revision
D104219: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard
Parents
rGecb68f1c8b11: [libc++abi] NFC: avoid a -Wunused-parameter warning
Branches
Unknown
Tags
Unknown