Diffusion LLVM Github Monorepo de1966e54279

Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"
de1966e54279
Actions

Authored by • thakis on Feb 9 2021, 8:00 AM.

Description

Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

This reverts commit 4a64d8fe392449b205e59031aad5424968cf7446.
Makes clang crash when buildling trivial iOS programs, see comment
after https://reviews.llvm.org/D92808#2551401

Details

Committed

• thakis

Feb 9 2021, 8:06 AM

Parents

rG230939244937: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

Branches

Unknown

Tags

Unknown

Reverts

D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR
rG4a64d8fe3924: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Event Timeline

• thakis committed rGde1966e54279: Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly" (authored by • thakis).Feb 9 2021, 8:06 AM

• thakis added reverted changes: rG4a64d8fe3924: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly, D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR.

• thakis mentioned this in D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR.Feb 9 2021, 8:07 AM

Changes (35)

Path

Size

clang/

lib/

CodeGen/

CGObjC.cpp

CodeGenFunction.h

CodeGenModule.h

test/

CodeGenObjC/

arc-rv-attr.m

arc-unsafeclaim.m

llvm/

docs/

LangRef.rst

include/

llvm/

Analysis/

IR/

lib/

Analysis/

ObjCARCInstKind.cpp

CodeGen/

SelectionDAG/

SelectionDAGBuilder.cpp

IR/

Instructions.cpp

LLVMContext.cpp

Target/

AArch64/

AArch64ISelLowering.cpp

Transforms/

ObjCARC/

ARCRuntimeEntryPoints.h

Scalar/

TailRecursionElimination.cpp

Utils/

InlineFunction.cpp

test/

Bitcode/

operand-bundles-bc-analyzer.ll

CodeGen/

AArch64/

call-rv-marker.ll

Transforms/

DeadArgElim/

deadretval.ll

Inline/

inline-retainRV-call.ll

ObjCARC/

contract-marker-funclet.ll

TailCallElim/

	deopt-bundle.ll
	operand-bundles.ll

operand-bundles.ll

rGde1966e54279

View Options

clang/lib/CodeGen/CGObjC.cpp

View Options

clang/lib/CodeGen/CodeGenFunction.h

View Options

clang/lib/CodeGen/CodeGenModule.h

View Options

clang/test/CodeGenObjC/arc-rv-attr.m

View Options

clang/test/CodeGenObjC/arc-unsafeclaim.m

View Options

llvm/docs/LangRef.rst

View Options

llvm/include/llvm/Analysis/ObjCARCUtil.h

View Options

llvm/include/llvm/IR/InstrTypes.h

View Options

llvm/include/llvm/IR/Intrinsics.td

View Options

llvm/include/llvm/IR/LLVMContext.h

View Options

llvm/lib/Analysis/ObjCARCInstKind.cpp

View Options

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

View Options

llvm/lib/IR/Instructions.cpp

View Options

llvm/lib/IR/LLVMContext.cpp

View Options

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

View Options

llvm/lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h

View Options

llvm/lib/Transforms/ObjCARC/ObjCARC.cpp

View Options

llvm/lib/Transforms/ObjCARC/ObjCARC.h

View Options

llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp

View Options

llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp

View Options

llvm/lib/Transforms/ObjCARC/PtrState.cpp

View Options

llvm/lib/Transforms/ObjCARC/PtrState.h

View Options

llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

View Options

llvm/lib/Transforms/Utils/InlineFunction.cpp

View Options

llvm/test/Bitcode/operand-bundles-bc-analyzer.ll

View Options

llvm/test/CodeGen/AArch64/call-rv-marker.ll

View Options

llvm/test/Transforms/DeadArgElim/deadretval.ll

View Options

llvm/test/Transforms/Inline/inline-retainRV-call.ll

View Options

llvm/test/Transforms/ObjCARC/contract-marker-funclet.ll

View Options

llvm/test/Transforms/ObjCARC/contract-rv-attr.ll

View Options

llvm/test/Transforms/ObjCARC/contract.ll

View Options

llvm/test/Transforms/ObjCARC/intrinsic-use.ll

View Options

llvm/test/Transforms/ObjCARC/rv.ll

View Options

llvm/test/Transforms/TailCallElim/deopt-bundle.ll

View Options

llvm/test/Transforms/TailCallElim/operand-bundles.ll

Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"de1966e54279Actions

Description

Details

Event Timeline

Changes (35)

rGde1966e54279

clang/lib/CodeGen/CGObjC.cpp

clang/lib/CodeGen/CodeGenFunction.h

clang/lib/CodeGen/CodeGenModule.h

clang/test/CodeGenObjC/arc-rv-attr.m

clang/test/CodeGenObjC/arc-unsafeclaim.m

llvm/docs/LangRef.rst

llvm/include/llvm/Analysis/ObjCARCUtil.h

llvm/include/llvm/IR/InstrTypes.h

llvm/include/llvm/IR/Intrinsics.td

llvm/include/llvm/IR/LLVMContext.h

llvm/lib/Analysis/ObjCARCInstKind.cpp

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

llvm/lib/IR/Instructions.cpp

llvm/lib/IR/LLVMContext.cpp

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

llvm/lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h

llvm/lib/Transforms/ObjCARC/ObjCARC.cpp

llvm/lib/Transforms/ObjCARC/ObjCARC.h

llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp

llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp

llvm/lib/Transforms/ObjCARC/PtrState.cpp

llvm/lib/Transforms/ObjCARC/PtrState.h

llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

llvm/lib/Transforms/Utils/InlineFunction.cpp

llvm/test/Bitcode/operand-bundles-bc-analyzer.ll

llvm/test/CodeGen/AArch64/call-rv-marker.ll

llvm/test/Transforms/DeadArgElim/deadretval.ll

llvm/test/Transforms/Inline/inline-retainRV-call.ll

llvm/test/Transforms/ObjCARC/contract-marker-funclet.ll

llvm/test/Transforms/ObjCARC/contract-rv-attr.ll

llvm/test/Transforms/ObjCARC/contract.ll

llvm/test/Transforms/ObjCARC/intrinsic-use.ll

llvm/test/Transforms/ObjCARC/rv.ll

llvm/test/Transforms/TailCallElim/deopt-bundle.ll

llvm/test/Transforms/TailCallElim/operand-bundles.ll

Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"
de1966e54279
Actions