HomePhabricator

ADT: SmallVector size/capacity use word-size integers when elements are small

Authored by browneee on Apr 24 2020, 7:26 PM.

Description

ADT: SmallVector size/capacity use word-size integers when elements are small

SmallVector currently uses 32bit integers for size and capacity to reduce
sizeof(SmallVector). This limits the number of elements to UINT32_MAX.

For a SmallVector<char>, this limits the SmallVector size to only 4GB.
Buffering bitcode output uses SmallVector<char>, but needs >4GB output.

This changes SmallVector size and capacity to conditionally use word-size
integers if the element type is small (<4 bytes). For larger elements types,
the vector size can reach ~16GB with 32bit size.

Making this conditional on the element type provides both the smaller
sizeof(SmallVector) for larger types which are unlikely to grow so large,
and supports larger capacities for smaller element types.

This recommit fixes the same template being instantiated twice on platforms
where uintptr_t is the same as uint32_t.

Details

Committed
browneeeApr 27 2020, 1:41 PM
Parents
rGf8990feb125a: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON
Branches
Unknown
Tags
Unknown