HomePhabricator

Update ConversionToLLVMDialect.md
Concern Raiseddaf207b75a88

Authored by Baden Hughes <580499+badenh@users.noreply.github.com> on Fri, Mar 20, 10:32 PM.

Description

Update ConversionToLLVMDialect.md

Minor editorial/typographic fixes

Details

Auditors
bondhugula
Committed
GitHub <noreply@github.com>Fri, Mar 20, 10:32 PM
Parents
rG85c30f3374d9: [X86] Reland D71360 Clean up UseInitArray initialization for…
Branches
Unknown
Tags
Unknown
References
refs/pull/194/head

Event Timeline

GitHub <noreply@github.com> committed rGdaf207b75a88: Update ConversionToLLVMDialect.md (authored by Baden Hughes <580499+badenh@users.noreply.github.com>).Fri, Mar 20, 10:32 PM
bondhugula raised a concern with this commit.Fri, Mar 20, 11:27 PM
bondhugula added a subscriber: bondhugula.

The revision title could be marked with an [NFC].

/mlir/docs/ConversionToLLVMDialect.md
55

The 'dynamically' is an adverb for sized here - so you don't need the hyphen although "dynamically sized" is functioning as an adjective, just like one wouldn't use "fully-shaped structure".

131

I'm not sure we need the 'also' here.

410

I don't think we need the then' here, but we drop the 'and' in the previous bullet.

563

dynamic ones

This commit now has outstanding concerns.Fri, Mar 20, 11:27 PM