HomePhabricator

[VPlan] Manage induction value creation using VPValues.

Authored by fhahn on Feb 3 2021, 9:45 AM.

Description

[VPlan] Manage induction value creation using VPValues.

This patch updates the induction value creation to use VPValues of
recipes to map the created values. This should bring is one step closer
to being able to optimize induction recipes directly in VPlan.

Currently widenIntOrFpInduction also generates vector values for a cast
of the induction, if it exists. Make this explicit by adding the cast
instruction to the values defined by the recipe.

Reviewed By: gilr

Differential Revision: https://reviews.llvm.org/D92284

Details

Event Timeline

Hi Florian, I just came across this patch. Could you please follow up to update descriptions of some methods that you have updated with the patch?
I did not check the most recent LLVM project version, thus if you see that a comment is irrelevant anymore then disregard it.
Thank you.
Valery

/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
528–530

The description now needs an update.

575

Please add description. It is not obvious why State is among arguments.

667–671

Please update this one too.

676–680

Would be nice to see arguments which were added described.

Hi Florian, I just came across this patch. Could you please follow up to update descriptions of some methods that you have updated with the patch?
I did not check the most recent LLVM project version, thus if you see that a comment is irrelevant anymore then disregard it.
Thank you.
Valery

Hi, thanks for the heads-up. I'll update the docs soon.