HomePhabricator

[ORC] Update symbol lookup to use a single callback with a required symbol…

Authored by lhames on Jun 7 2019, 12:33 PM.

Description

[ORC] Update symbol lookup to use a single callback with a required symbol state rather than two callbacks.

The asynchronous lookup API (which the synchronous lookup API wraps for
convenience) used to take two callbacks: OnResolved (called once all requested
symbols had an address assigned) and OnReady to be called once all requested
symbols were safe to access). This patch updates the asynchronous lookup API to
take a single 'OnComplete' callback and a required state (SymbolState) to
determine when the callback should be made. This simplifies the common use case
(where the client is interested in a specific state) and will generalize neatly
as new states are introduced to track runtime initialization of symbols.

Clients who were making use of both callbacks in a single query will now need to
issue two queries (one for SymbolState::Resolved and another for
SymbolState::Ready). Synchronous lookup API clients who were explicitly passing
the WaitOnReady argument will now need neeed to pass a SymbolState instead (for
'WaitOnReady == true' use SymbolState::Ready, for 'WaitOnReady == false' use
SymbolState::Resolved). Synchronous lookup API clients who were using default
arugment values should see no change.

llvm-svn: 362832

Details

Committed
lhamesJun 7 2019, 12:33 PM
Parents
rG8cfb14fad6e6: docs: Update partitioning docs now that the feature is fully landed.
Branches
Unknown
Tags
Unknown