HomePhabricator

[Driver] Verify GCCInstallation is valid
d1cc4b0b3caaUnpublished

Authored by nickdesaulniers on May 21 2019, 2:21 PM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[Driver] Verify GCCInstallation is valid

Summary:
Values returned by GCCInstallation.getParentLibPath() and
GCCInstallation.getTriple() are not valid unless
GCCInstallation.isValid() returns true. This has previously been
ignored, and the former two values were used without checking whether
GCCInstallation is valid. This led to the bad path "/../bin" being added
to the list of program paths.

author: danielmentz "Daniel Mentz <danielmentz@google.com>"

Reviewers: #clang, tstellar, srhines

Reviewed By: srhines

Subscribers: danielmentz, ormris, nickdesaulniers, srhines, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57930

llvm-svn: 361314

Details

Committed
sidorovdMay 24 2019, 5:44 AM
Reviewer
srhines
Differential Revision
D57930: [Driver] Verify GCCInstallation is valid
Parents
rG0727a7213bc4: [libFuzzer] Reduce flakiness of merge-sigusr.test.
Branches
Unknown
Tags
Unknown