HomePhabricator

[gen_ast_dump_json_test.py] Copy to binary directory to omit --clang argument
Concern Raisedd09e811cb4da

Authored by arichardson on Nov 12 2019, 3:47 AM.

Description

[gen_ast_dump_json_test.py] Copy to binary directory to omit --clang argument

The script will now check if a clang binary exists in the same directory
and default to that instead of requiring a --clang argument. The script
is copied to the clang build directory using CMake configure_file() with
COPYONLY. This ensures that the version in the build directory is updated
any time the source version changes.

See https://reviews.llvm.org/D70119

Details

Auditors
mgorny
Committed
arichardsonNov 15 2019, 4:52 AM
Parents
rG90dbb47616da: [gen_ast_dump_json_test.py] Skip manual tests when using --update
Branches
Unknown
Tags
Unknown

Event Timeline

Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> committed rGd09e811cb4da: [gen_ast_dump_json_test.py] Copy to binary directory to omit --clang argument (authored by Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>).Nov 15 2019, 4:52 AM
mgorny raised a concern with this commit.Dec 14 2019, 12:43 PM
mgorny added a subscriber: mgorny.
mgorny added inline comments.
/clang/test/CMakeLists.txt
141

This breaks standalone builds. LLVM_TOOLS_BINARY_DIR may refer to /usr/something which is certainly *not* where CMake is supposed to write to.

This commit now has outstanding concerns.Dec 14 2019, 12:43 PM