HomePhabricator

[mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass.

Authored by Vasileios Kalintiris <Vasileios.Kalintiris@imgtec.com> on Oct 27 2016, 8:50 AM.

Description

[mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass.

r282428 added the MipsOptimizePICCall as an opt-in pass that can be
skipped when using the -opt-bisect-limit option. However, this pass is
needed because it generates code that conforms to the o32 ABI
specification by using the $t9 register for PIC calls with JALR
instructions.

This bug was exposed by the fact that skipFunction() also checks for
the "optnone" attribute. This caused functions with that attribute to
break the requirements of the o32 ABI.

llvm-svn: 285305

Event Timeline

Vasileios Kalintiris <Vasileios.Kalintiris@imgtec.com> committed rGcfb005a0ee6c: [mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass. (authored by Vasileios Kalintiris <Vasileios.Kalintiris@imgtec.com>).Oct 27 2016, 8:50 AM