HomePhabricator

[analyzer] Fix an assertion failure if plugins added dependencies

Authored by Kristof Umann <kristof.umann@ericsson.com> on Apr 19 2019, 4:01 AM.

Description

[analyzer] Fix an assertion failure if plugins added dependencies

Ideally, there is no reason behind not being able to depend on checkers that
come from a different plugin (or on builtin checkers) -- however, this is only
possible if all checkers are added to the registry before resolving checker
dependencies. Since I used a binary search in my addDependency method, this also
resulted in an assertion failure (due to CheckerRegistry::Checkers not being
sorted), since the function used by plugins to register their checkers
(clang_registerCheckers) calls addDependency.

This patch resolves this issue by only noting which dependencies have to
established when addDependency is called, and resolves them at a later stage
when no more checkers are added to the registry, by which point
CheckerRegistry::Checkers is already sorted.

Differential Revision: https://reviews.llvm.org/D59461

llvm-svn: 358750

Event Timeline

Kristof Umann <kristof.umann@ericsson.com> committed rGcd3f14743972: [analyzer] Fix an assertion failure if plugins added dependencies (authored by Kristof Umann <kristof.umann@ericsson.com>).Apr 19 2019, 4:01 AM