HomePhabricator

[BasicAA] Make BasicAA a cfg pass.
caa755f90e37Unpublished

Authored by asbirlea on Feb 7 2020, 10:15 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[BasicAA] Make BasicAA a cfg pass.

Summary:
Part of the changes in D44564 made BasicAA not CFG only due to it using
PhiAnalysisValues which may have values invalidated.
Subsequent patches (rL340613) appear to have addressed this limitation.

BasicAA should not be invalidated by non-CFG-altering passes.
A concrete example is MemCpyOpt which preserves CFG, but we are testing
it invalidates BasicAA.

llvm-dev RFC: https://groups.google.com/forum/#!topic/llvm-dev/eSPXuWnNfzM

Reviewers: john.brawn, sebpop, hfinkel, brzycki

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74353

(cherry picked from commit 0cecafd647ccd9d0acc5968d4d6e80c1cbdee275)

Details

Committed
tstellarJun 23 2020, 3:42 PM
Differential Revision
D74353: [BasicAA] Make BasicAA a cfg pass.
Parents
rG1f3be0e9b7b4: [PowerPC] Do not assume operand of ADDI is an immediate
Branches
Unknown
Tags
Unknown