HomePhabricator

[AArch64][SVE] Fix crash with icmp+select

Authored by CarolineConcatto on Apr 12 2021, 3:22 AM.

Description

[AArch64][SVE] Fix crash with icmp+select

This patch changes the lowering of SELECT_CC from Legal to Expand for scalable
vector and adds support for scalable vectors in performSelectCombine.

When selecting the nodes to lower in visitSELECT it checks if it is possible to
use SELECT_CC in cases where SETCC is followed by SELECT. visistSELECT checks
if SELECT_CC is legal or custom to replace SELECT by SELECT_CC.
SELECT_CC used to be legal for scalable vector, so the node changes to
SELECT_CC. This used to crash the compiler as there is no support for SELECT_CC
with scalable vectors. So now the compiler lowers to VSELECT instead of
SELECT_CC.

Differential Revision: https://reviews.llvm.org/D100485

Details

Committed
CarolineConcattoApr 21 2021, 6:16 AM
Differential Revision
D100485: [AArch64][SVE] Fix crash with icmp+select
Parents
rG70ab76a81b98: AMDGPU: Fix indirect tail calls
Branches
Unknown
Tags
Unknown