HomePhabricator

[CodeView] Add support for ref-qualified member functions.

Authored by zturner on Nov 20 2018, 2:13 PM.

Description

[CodeView] Add support for ref-qualified member functions.

When you have a member function with a ref-qualifier, for example:

struct Foo {

void Func() &;
void Func2() &&;

};

clang-cl was not emitting this information. Doing so is a bit
awkward, because it's not a property of the LF_MFUNCTION type, which
is what you'd expect. Instead, it's a property of the this pointer
which is actually an LF_POINTER. This record has an attributes
bitmask on it, and our handling of this bitmask was all wrong. We
had some parts of the bitmask defined incorrectly, but importantly
for this bug, we didn't know about these extra 2 bits that represent
the ref qualifier at all.

Differential Revision: https://reviews.llvm.org/D54667

llvm-svn: 347354

Details

Committed
zturnerNov 20 2018, 2:13 PM
Differential Revision
D54667: [CodeView] Emit proper debug info for ref-qualified member functions
Parents
rG3826566c044e: [CodeView] Mark this pointers as const.
Branches
Unknown
Tags
Unknown