HomePhabricator

[ELF] Fix problems with fabricateDefaultCommands() and --section-start

Authored by peter.smith on May 3 2017, 1:44 AM.

Description

[ELF] Fix problems with fabricateDefaultCommands() and --section-start

The --section-start <name>=<address> needs to be translated into equivalent
linker script commands. There are a couple of problems with the existing
implementation:

  • The --section-start with the lowest address is assumed to be at the start

of the map. This assumption is incorrect, we have to iterate through the
SectionStartMap to find the lowest address.

  • The addresses in --section-start were being over-aligned when the

sections were marked as PageAlign. This is inconsistent with the use of
SectionStartMap in fixHeaders(), and can cause problems when the PageAlign
causes an "unable to move location counter backward" error when the
--section-start with PageAlign is aligned to an address higher than the next
--section-start. The ld.bfd and ld.gold seem to be more consistent with this
approach but this is not a well specified area.

This change fixes the problems above and also corrects a typo in which
fabricateDefaultCommands() is called with the wrong parameter, it should be
called with AllocateHeader not Config->MaxPageSize.

Differential Revision: https://reviews.llvm.org/D32749

llvm-svn: 302007