HomePhabricator

[GN] Generation failure caused by trailing space in file name

Authored by phosek on Jun 23 2019, 4:12 PM.

Description

[GN] Generation failure caused by trailing space in file name

When I executed gn.py gen out/gn I got the following error:

ERROR at compiler-rt/lib/builtins/BUILD.gn:162:7: Only source, header, and object files belong in the sources of a static_library. compiler-rt/lib/builtins/emutls.c is not one of the valid types.

"emutls.c ",
^----------

See //compiler-rt/lib/BUILD.gn:3:5: which caused the file to be included.

"//compiler-rt/lib/builtins",
^---------------------------

It turns out to be that the latest gn doesn't accept ill-format file name. And the emutls.c above has a trailing space.
Remove the trailing space should work.

Patch By: myhsu
Differential Revision: https://reviews.llvm.org/D63449

llvm-svn: 364162

Details

Committed
phosekJun 23 2019, 4:12 PM
Differential Revision
D63449: [GN] Generation failure caused by trailing space in file name
Parents
rGfb2bd4a9398b: Use C++11 implementation of unique_ptr in C++03.
Branches
Unknown
Tags
Unknown