HomePhabricator

[clangd] DefineOutline won't copy virtual specifiers on methods

Authored by njames93 on Mar 3 2020, 1:58 AM.

Description

[clangd] DefineOutline won't copy virtual specifiers on methods

Summary:
The define out of line refactor tool previously would copy the virtual, override and final specifier into the out of line method definition.
This results in malformed code as those specifiers aren't allowed outside the class definition.

Reviewers: hokein, kadircet

Reviewed By: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D75429

(cherry picked from commit b2666ccca0277371a09e43a0a5a0f78029ba81e5)

Details

Committed
hansMar 4 2020, 12:11 AM
Reviewer
kadircet
Differential Revision
D75429: [clangd] DefineOutline won't copy virtual specifiers on methods
Parents
rG3ef42c184ac3: ReleaseNotes: Formatting and typo fixes.
Branches
Unknown
Tags
Unknown