HomePhabricator

[Inline] prevent inlining on stack protector mismatch

Authored by nickdesaulniers on Dec 2 2020, 10:44 AM.

Description

[Inline] prevent inlining on stack protector mismatch

It's common for code that manipulates the stack via inline assembly or
that has to set up its own stack canary (such as the Linux kernel) would
like to avoid stack protectors in certain functions. In this case, we've
been bitten by numerous bugs where a callee with a stack protector is
inlined into an attribute((no_stack_protector)) caller, which
generally breaks the caller's assumptions about not having a stack
protector. LTO exacerbates the issue.

While developers can avoid this by putting all no_stack_protector
functions in one translation unit together and compiling those with
-fno-stack-protector, it's generally not very ergonomic or as
ergonomic as a function attribute, and still doesn't work for LTO. See also:
https://lore.kernel.org/linux-pm/20200915172658.1432732-1-rkir@google.com/
https://lore.kernel.org/lkml/20200918201436.2932360-30-samitolvanen@google.com/T/#u

SSP attributes can be ordered by strength. Weakest to strongest, they
are: ssp, sspstrong, sspreq. Callees with differing SSP attributes may be
inlined into each other, and the strongest attribute will be applied to the
caller. (No change)

After this change:

  • A callee with no SSP attributes will no longer be inlined into a caller with SSP attributes.
  • The reverse is also true: a callee with an SSP attribute will not be inlined into a caller with no SSP attributes.
  • The alwaysinline attribute overrides these rules.

Functions that get synthesized by the compiler may not get inlined as a
result if they are not created with the same stack protector function
attribute as their callers.

Alternative approach to https://reviews.llvm.org/D87956.

Fixes pr/47479.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed By: rnk, MaskRay

Differential Revision: https://reviews.llvm.org/D91816

Details

Committed
nickdesaulniersDec 2 2020, 11:00 AM
Reviewer
rnk
Differential Revision
D91816: [Inline] prevent inlining on stack protector mismatch
Parents
rGe5085a62d1e7: [gn build] Port a65d8c5d720
Branches
Unknown
Tags
Unknown