HomePhabricator

[lldb/PlatformDarwin] Always delete destination file first in PutFile

Authored by friss on Mar 19 2020, 8:43 AM.

Description

[lldb/PlatformDarwin] Always delete destination file first in PutFile

Summary:
The default behavior of Platform::PutFile is to open the file and
truncate it if it already exists. This works fine and is a sensible
default, but it interacts badly with code-signing on iOS, as doing so
invalidates the signature of the file (even if the new content has a
valid code signature).

We have a couple tests which on purpose reload a different binary with
the same name. Those tests are currently broken because of the above
interaction.

This patch simply makes the Darwin platform unconditionally delete the
destination file before sending the new one to work around this issue.

Reviewers: jasonmolenda

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D76450

Details

Committed
frissMar 23 2020, 2:34 PM
Differential Revision
D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile
Parents
rGf3018068517e: [lld] Enabling loading LLVM pass plugins
Branches
Unknown
Tags
Unknown