HomePhabricator

[LLDB] Fix the handling of unnamed bit-fields when parsing DWARF
b5cf89265181Unpublished

Authored by shafik on Jan 23 2020, 2:42 PM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

We ran into an assert when debugging clang and performing an expression on a class derived from DeclContext. The assert was indicating we were getting the offsets wrong for RecordDeclBitfields. We were getting both the size and offset of unnamed bit-field members wrong. We could fix this case with a quick change but as I extended the test suite to include more combinations we kept finding more cases that were being handled incorrectly. A fix that handled all the new cases as well as the cases already covered required a refactor of the existing technique.

Differential Revision: https://reviews.llvm.org/D72953

(cherry picked from commit fcaf5f6c01a09f23b948afb8c91c4dd951d4525e)

Details

Committed
hansJan 27 2020, 6:10 AM
Differential Revision
D72953: Fix the handling of unnamed bit-fields when parsing DWARF
Parents
rG2c9cb89d0d00: [Support] Fix race in threading test, found by TSan
Branches
Unknown
Tags
Unknown