HomePhabricator

[LTO] Remove values from non-prevailing comdats

Authored by tejohnson on Jun 30 2017, 7:03 AM.

Description

[LTO] Remove values from non-prevailing comdats

Summary:
When linking a regular LTO module, if it has any non-prevailing values
(dropped to available_externally) in comdats, we need to do more than
just remove those values from their comdat. We also remove all values
from that comdat, so as to avoid leaving an incomplete comdat.

This is necessary in case we are compiling in mixed regular and ThinLTO
mode, since the resulting regularLTO native object is always linked into
the final binary first. We need to prevent the linker from selecting an
incomplete comdat that was not the prevailing copy.

Fixes PR32980.

Reviewers: pcc, rafael

Subscribers: mehdi_amini, david2050, llvm-commits, inglorion

Differential Revision: https://reviews.llvm.org/D34803

llvm-svn: 306826

Details

Committed
tejohnsonJun 30 2017, 7:03 AM
Differential Revision
D34803: [LTO] Remove values from non-prevailing comdats
Parents
rG7b6097ce737a: [OPENMP] Initial support for taskloop reductions.
Branches
Unknown
Tags
Unknown