HomePhabricator

[lldb] Refine ThreadPlan::ShouldAutoContinue

Authored by kastiglione on Feb 19 2021, 11:26 AM.

Description

[lldb] Refine ThreadPlan::ShouldAutoContinue

Adjust ShouldAutoContinue to be available to any thread plan previous to the plan that
explains a stop, not limited to the parent to the plan that explains the stop.

Before this change, Thread::ShouldStop did the following:

  1. find the plan that explains the stop
  2. if it's not a master plan, continue processing previous (aka parent) plans
  3. first, call ShouldAutoContinue on the immediate parent of the explaining plan
  4. then loop over previous plans, calling ShouldStop and MischiefManaged

Of note, the iteration in step 4 does not call ShouldAutoContinue, so again only the
plan just prior to the explaining plan is given the opportunity to override whether to
continue or stop.

This commit changes the loop call ShouldAutoContinue, giving each plan the opportunity
to override ShouldStop of previous plans.

Why? This allows a plan to do the following:

  1. mark itself done and be popped off the stack
  2. allow parent plans to finish their work, and to also be popped off the stack
  3. and finally, have the thread continue, not stop

This is useful for stepping into async functions. A plan will would step far enough
enough to set a breakpoint on the async target, and then use ShouldAutoContinue to
unwind the necessary stepping, and then have the calling thread continue.

Differential Revision: https://reviews.llvm.org/D97076

Details

Committed
kastiglioneFeb 20 2021, 5:25 PM
Differential Revision
D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue
Parents
rGfa211f3ce9a9: Update test error string post pass registration change
Branches
Unknown
Tags
Unknown