HomePhabricator

[Attributor][FIX] Do not replace a value with a non-dominating instruction

Authored by jdoerfert on Jun 24 2021, 11:12 AM.

Description

[Attributor][FIX] Do not replace a value with a non-dominating instruction

We have to be careful when we replace values to not use a non-dominating
instruction. It makes sense that simplification offers those as
"simplified values" but we can't manifest them in the IR without PHI
nodes. In the future we should consider potentially adding those PHI
nodes.