HomePhabricator

[mlir][sparse] mask reduction update

Authored by aartbik on Mar 4 2021, 7:05 PM.

Description

[mlir][sparse] mask reduction update

Reduction updates should be masked, just like the load and stores.
Note that alternatively, we could use the fact that masked values are
zero of += updates and mask invariants to get this working but that
would not work for *= updates. Masking the update itself is cleanest.
This change also replaces the constant mask with a broadcast of "true"
since this constant folds much better for various folding patterns.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D98000

Details

Committed
aartbikMar 5 2021, 8:56 AM
Reviewer
nicolasvasilache
Differential Revision
D98000: [mlir][sparse] mask reduction update
Parents
rG87d5b34c2494: [X86] X86ISelDAGToDAG.cpp - include cstdint instead of stdint.h NFCI.
Branches
Unknown
Tags
Unknown