HomePhabricator

Fix runInTerminal failures on Windows

Authored by wallace on Jan 27 2021, 1:02 PM.

Description

Fix runInTerminal failures on Windows

stella.stemenova mentioned in https://reviews.llvm.org/D93951 failures on Windows for this test.

I'm fixing the macro definitions and disabling the tests for python
versions lower than 3.7. I'll figure out that actual issue with
python3.6 after the buildbots are fine again.

Details

Committed
wallaceJan 27 2021, 1:17 PM
Parents
rG262c50856a37: [sanitizer] Fix crash on empty strings.
Branches
Unknown
Tags
Unknown

Event Timeline

stella.stamenova added inline comments.
/lldb/test/API/tools/lldb-vscode/runInTerminal/TestVSCode_runInTerminal.py
36

The failures that we are seeing on Ubuntu are independent of python version. We use the same version of python (3.6) for debug and release builds and the test only fails in release.

I think that's because I'm not running all the tests for Debug builds, as they would timeout. I've noticed that an error is due to the use of capture_output when doing Popen, but I use subprocess in other places as well for this feature, so I want to first set up my environment for using python3.6 and making sure everything works well.

This worked almost, but not quite. It seems you did not fully update RunInTerminal.cpp.

Damn, I gotta fix that