HomePhabricator

DebugInfo: Include DW_AT_base_addr even in gmlt with no inline functions

Authored by dblaikie on Dec 18 2019, 5:10 PM.

Description

DebugInfo: Include DW_AT_base_addr even in gmlt with no inline functions

Since the address pool doesn't get populated in this case (due to the
lack of inlining, no child DIEs are added to the CU - so no addresses
are needed for the DIEs themselves) until the range list is emitted - at
the time the attributes are added to the CU, the address pool is empty.
So check whether the address pool will be used for the range lists & add
an addr_base if that's the case.

Details

Committed
dblaikieDec 18 2019, 5:14 PM
Parents
rG553a727f5f64: [clang] Remove -Wexperimental-float-control.
Branches
Unknown
Tags
Unknown

Event Timeline

Hi @dblaikie seems this commit makes check llvm fail on PowerPC.

: 'RUN: at line 1';  ./llvm-project/llvm/build/bin/llc --function-sections < ./llvm-project/llvm/test/DebugInfo/X86/gmlt-empty-base-address.ll -filetype=obj | ./llvm-project/llvm/build/bin/llvm-dwarfdump -v -debug-info - | ./llvm-project/llvm/build/bin/FileCheck ./llvm-project/llvm/test/DebugInfo/X86/gmlt-empty-base-address.ll
--
Exit Code: 1

Command Output (stderr):
--
'x86-64' is not a recognized processor for this target (ignoring processor)
'+cx8' is not a recognized feature for this target (ignoring feature)
'+fxsr' is not a recognized feature for this target (ignoring feature)
'+mmx' is not a recognized feature for this target (ignoring feature)
'+sse' is not a recognized feature for this target (ignoring feature)
'+sse2' is not a recognized feature for this target (ignoring feature)
'+x87' is not a recognized feature for this target (ignoring feature)
'x86-64' is not a recognized processor for this target (ignoring processor)
'x86-64' is not a recognized processor for this target (ignoring processor)
'x86-64' is not a recognized processor for this target (ignoring processor)
'+cx8' is not a recognized feature for this target (ignoring feature)
'+fxsr' is not a recognized feature for this target (ignoring feature)
'+mmx' is not a recognized feature for this target (ignoring feature)
'+sse' is not a recognized feature for this target (ignoring feature)
'+sse2' is not a recognized feature for this target (ignoring feature)
'+x87' is not a recognized feature for this target (ignoring feature)
'x86-64' is not a recognized processor for this target (ignoring processor)
error: failed to compute relocation: R_PPC64_REL32, Invalid data was encountered while parsing the file
error: failed to compute relocation: R_PPC64_REL32, Invalid data was encountered while parsing the file
/home/czhengsz/llvm_deliver/llvm-project/llvm/test/DebugInfo/X86/gmlt-empty-base-address.ll:4:10: error: CHECK: expected string not found in input
; CHECK: [0x0000000000000000, 0x0000000000000006) ".text._Z2f1v"
         ^
<stdin>:15:2: note: scanning from here
 [0x0000000000000000, 0x0000000000000010) ".text._Z2f1v"
 ^

--