HomePhabricator

Replace std::foo with std::foo_t in LLVM.

Authored by Caroline Lebar <caroline.s.lebar@gmail.com> on Feb 12 2020, 4:14 PM.

Description

Replace std::foo with std::foo_t in LLVM.

This patch is replacements missed in my last change doing this across LLVM.

No functional change, although I think there was a missing typename
in struct conjunction that is now fixed.

Event Timeline

Caroline Lebar <caroline.s.lebar@gmail.com> committed rGa4384c756bd8: Replace std::foo with std::foo_t in LLVM. (authored by Caroline Lebar <caroline.s.lebar@gmail.com>).Feb 12 2020, 4:14 PM

These changes break few Windows builders

The first error:

FAILED: lib/IR/CMakeFiles/LLVMCore.dir/PassTimingInfo.cpp.obj 
C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\IR -IC:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\llvm\lib\IR -Iinclude -IC:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\llvm\include -D__OPTIMIZE__ /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4345 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /MD /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\IR\CMakeFiles\LLVMCore.dir\PassTimingInfo.cpp.obj /Fdlib\IR\CMakeFiles\LLVMCore.dir\LLVMCore.pdb /FS -c C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\llvm\lib\IR\PassTimingInfo.cpp
C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\llvm\include\llvm/ADT/FunctionExtras.h(260): error C3520: 'ParamTs': parameter pack must be expanded in this context

please see logs for more details.

Sorry, but I'm going to revert this commit.