HomePhabricator

Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
a39b2d0d9436Unpublished

Authored by jankratochvil on May 21 2019, 10:38 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Remove SymbolFileDWARF * when there is already DWARFUnit *

In D61502#1503247 @clayborg suggested that SymbolFileDWARF *dwarf2Data is
really redundant in all the calls with also having DWARFUnit *cu. So remove it.

One SymbolFileDWARF * nullptr check
(DWARFDebugInfoEntry::GetDIENamesAndRanges) could be removed, other two nullptr
checks (DWARFDebugInfoEntry::GetName and DWARFDebugInfoEntry::AppendTypeName)
need to stay in place (now for DWARFUnit *).

Differential Revision: https://reviews.llvm.org/D62011

llvm-svn: 361277

Details

Committed
sidorovdMay 24 2019, 5:43 AM
Differential Revision
D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
Parents
rGb18297d7a43d: [Dsymutil] Remove redundant argument (NFC)
Branches
Unknown
Tags
Unknown