HomePhabricator

Replace WINLOG_*** macros with LLDB_LOG

Authored by labath on Feb 22 2017, 2:38 AM.

Description

Replace WINLOG_*** macros with LLDB_LOG

Summary:
The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you have to go the usual lldb
route of getting a Log* variable first. While this means you have to
write at least two statements, it usually means that each statement will
fit on a single line, whereas fitting the WINLOG invocation on a single
line was almost impossible. So the total size of code does not increase
even in functions with a single log statement, and functions with more
logging get shorter.

The downside here is reduced flexibility in specifying the log
categories, which a couple of functions used quite heavily (e.g.
RefreshStateAfterStop). For these I chose a single category used most
prominently and put everything into that, although a solution with
multiple log variables is definitely possible.

Reviewers: zturner, amccarth

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D30172

llvm-svn: 295822

Details

Committed
labathFeb 22 2017, 2:38 AM
Differential Revision
D30172: Replace WINLOG_*** macros with LLDB_LOG
Parents
rG048b3ece1db9: Add format_provider for the MemoryRegionInfo::OptionalBool enum
Branches
Unknown
Tags
Unknown