HomePhabricator

Re-apply "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation"

Authored by lhames on Oct 22 2020, 11:24 PM.

Description

Re-apply "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation"

This re-applies e2fceec2fd1 with fixes. Apparently we already *do* support
relaxation for ELF, so we need to make sure the test case allocates a slab at
a fixed address, and that the R_X86_64_REX_GOTPCRELX test references an external
that is guaranteed to be out of range.

Details

Committed
lhamesOct 23 2020, 9:48 AM
Parents
rG1e113c078a56: [AArch64][SVE] Fix umin/umax lowering to handle out of range imm.
Branches
Unknown
Tags
Unknown

Event Timeline

I think it's not a big deal, but you may want to revert the named_data change. See inline comment.

/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s
61

The consuming code hasn't changed, i.e. it still uses movl. The new test for REX_GOTPCRELX uses the new absolute symbol external_data that gets injected from the command line.