HomePhabricator

MinidumpParser: use minidump parser in llvm/Object

Authored by labath on Apr 5 2019, 12:56 AM.

Description

MinidumpParser: use minidump parser in llvm/Object

This patch removes the lower layers of the minidump parsing code from
the MinidumpParser class, and replaces it with the minidump parser in
llvm.

Not all functionality is already avaiable in the llvm class, but it is
enough for us to be able to stop enumerating streams manually, and rely
on the minidump directory parsing code from the llvm class.

This also removes some checked-in binaries which were used to test error
handling in the parser, as the error handling is now done (and tested)
in llvm. Instead I just add one test that ensures we correctly propagate
the errors reported by the llvm parser. The input for this test can be
written in yaml instead of a checked-in binary.

llvm-svn: 357748

Details

Committed
labathApr 5 2019, 12:56 AM
Parents
rG546bccf61c62: TestVCCode_step: replace assertTrue with more specific assertions
Branches
Unknown
Tags
Unknown