HomePhabricator

[MemorySSAUpdater] Avoid creating self-referencing MemoryDefs

Authored by labrinea on Sep 11 2018, 7:29 AM.

Description

[MemorySSAUpdater] Avoid creating self-referencing MemoryDefs

Fix for https://bugs.llvm.org/show_bug.cgi?id=38807, which occurred
while compiling SemaTemplateInstantiate.cpp with clang and GVNHoist
enabled. In the following example:

1=def(entry)
/        \

2=def(1) 4=def(1)
3=def(2) 5=def(4)

When removing the MemoryDef 2=def(1) from its basic block, and just
before adding it to the end of the parent basic block, we first
replace all its uses with the defining memory access:

3=def(2) -> 3=def(1)

Then we call insertDef for adding 2=def(1) to the parent basic block,
where we replace the uses of 1=def(entry) with 2=def(1). Doing so we
create a self reference:

2=def(1) -> 2=def(2) (bad)
3=def(1) -> 3=def(2) (ok)
4=def(1) -> 4=def(2) (ok)

Differential Revision: https://reviews.llvm.org/D51801

llvm-svn: 341947

Details

Committed
labrineaSep 11 2018, 7:29 AM
Differential Revision
D51801: [MemorySSAUpdater] Avoid creating self-referencing MemoryDefs
Parents
rG4beb2f964b4d: [PerfMonitor] Fix rdtscp callsites
Branches
Unknown
Tags
Unknown