HomePhabricator

[clang-tidy] new performance-no-automatic-move check.

Authored by courbet on Nov 18 2019, 4:22 AM.

Description

[clang-tidy] new performance-no-automatic-move check.

Summary: The check flags constructs that prevent automatic move of local variables.

Reviewers: aaron.ballman

Subscribers: mgorny, xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70390

Details

Committed
courbetNov 21 2019, 11:47 PM
Differential Revision
D70390: [clang-tidy] new performance-no-automatic-move check.
Parents
rG036790f98899: [DAGCombiner] Allow zextended load combines.
Branches
Unknown
Tags
Unknown

Event Timeline

Jeroen added a subscriber: Jeroen.Nov 25 2019, 7:39 AM

Does it make sense of extending the unit test with auto, auto & and auto && examples for the variables?

Does it make sense of extending the unit test with auto, auto & and auto && examples for the variables?

No strong opinion. I don't think it really makes a difference (we're not really testing inference rules here), but if you think there are cases when the type inference is misleading, we can add a test for it.