HomePhabricator

[FileCheck] Introduce substitution subclasses
94aa1e382019Unpublished

Authored by thopre on May 22 2019, 5:10 PM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[FileCheck] Introduce substitution subclasses

Summary:
With now a clear distinction between string and numeric substitutions,
this patch introduces separate classes to represent them with a parent
class implementing the common interface. Diagnostics in
printSubstitutions() are also adapted to not require knowing which
substitution is being looked at since it does not hinder clarity and
makes the implementation simpler.

Reviewers: jhenderson, jdenny, probinson, arichardson

Subscribers: llvm-commits, probinson, arichardson, hiraditya

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62241

llvm-svn: 361446

Details

Committed
sidorovdMay 24 2019, 5:44 AM
Differential Revision
D62241: [FileCheck] Introduce substitution subclasses
Parents
rGc01e4763f37a: FileCheck: Improve FileCheck variable terminology
Branches
Unknown
Tags
Unknown