HomePhabricator

[YAML] Fix YAML tags appearing before the start of sequence elements

Authored by beanz on Jun 28 2016, 2:10 PM.

Description

[YAML] Fix YAML tags appearing before the start of sequence elements

Our existing yaml::Output code writes tags immediately when mapTag is called, without any state handling. This results in tags on sequence elements being written before the element itself. For example, we see this:

SomeArray: !elem_type

  • key1: 1 key2: 2 !elem_type2
  • key3: 3 key4: 4

We should instead see:

SomeArray:

  • !elem_type key1: 1 key2: 2
  • !elem_type2 key3: 3 key4: 4

Our reader handles reading properly, so this bug only impacts writing yaml sequences with tagged elements.

As a test for this I've modified the Mach-O yaml encoding to allways apply the !mach-o tag when encoding MachOYAML::Object entries. This results in the !mach-o tag appearing as expected in dumped fat files.

llvm-svn: 274067

Details

Committed
beanzJun 28 2016, 2:10 PM
Parents
rG347db3e18ee7: [SystemZ] Use NILL instruction instead of NILF where possible
Branches
Unknown
Tags
Unknown