HomePhabricator

[clangd] New ParsingCallback for semantics changes

Authored by kadircet on May 19 2021, 4:45 AM.

Description

[clangd] New ParsingCallback for semantics changes

Previously notification of the Server about semantic happened strictly
before notification of the AST thread.
Hence a racy Server could make a request (like semantic tokens) after
the notification, with the assumption that it'll be served fresh
content. But it wasn't true if AST thread wasn't notified about the
change yet.

This change reverses the order of those notifications to prevent racy
interactions.

Differential Revision: https://reviews.llvm.org/D102761

Details

Committed
kadircetMay 26 2021, 7:57 AM
Differential Revision
D102761: [clangd] New ParsingCallback for semantics changes
Parents
rG5f500d73cd1a: [MCA] Add a test for PR50483. NFC
Branches
Unknown
Tags
Unknown