HomePhabricator

[MLIR] Correct linkage of lowered globalop

Authored by wsmoses on Aug 17 2021, 3:22 PM.

Description

[MLIR] Correct linkage of lowered globalop

LLVM considers global variables marked as externals to be defined within the module if it is initialized (including to an undef). Other external globals are considered as being defined externally and imported into the current translation unit. Lowering of MLIR Global Ops does not properly propagate undefined initializers, resulting in a global which is expected to be defined within the current TU, not being defined.

Differential Revision: https://reviews.llvm.org/D108252

Details

Committed
wsmosesAug 18 2021, 8:09 AM
Differential Revision
D108252: [MLIR] Correct linkage of lowered globalop
Parents
rG7151a8aada21: [PowerPC][AIX] llvm-readobj: Convert some errors to warnings.
Branches
Unknown
Tags
Unknown