HomePhabricator

[IRMover] Don't map globals if their types are the same

Authored by pirama on Sep 11 2019, 11:35 AM.

Description

[IRMover] Don't map globals if their types are the same

Summary:
During IR Linking, if the types of two globals in destination and source
modules are the same, it can only be because the global in the
destination module is originally from the source module and got added to
the destination module from a shared metadata.

We shouldn't map this type to itself in case the type's components get
remapped to a new type from the destination (for instance, during the
loop over SrcM->getIdentifiedStructTypes() further below in
IRLinker::computeTypeMapping()).

Fixes PR40312.

Reviewers: tejohnson, pcc, srhines

Subscribers: mehdi_amini, hiraditya, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66814

llvm-svn: 371643

Details

Committed
piramaSep 11 2019, 11:35 AM
Differential Revision
D66814: [IRMover] Don't map globals if their types are the same
Parents
rGabcc2a879c95: [MS] Consder constexpr globals to be inline, as in C++17
Branches
Unknown
Tags
Unknown