HomePhabricator

[clang][AVR] Improve avr-ld command line options

Authored by benshi001 on Jan 24 2021, 8:01 PM.

Description

[clang][AVR] Improve avr-ld command line options

Event Timeline

jansvoboda11 raised a concern with this commit.Jan 25 2021, 12:21 AM
jansvoboda11 added a subscriber: jansvoboda11.

This commit seems to cause build failures across the board, e.g. http://lab.llvm.org:8011/#/builders/93/builds/1607

This commit now has outstanding concerns.Jan 25 2021, 12:21 AM

I have reverted this commit, and will redo it after a careful check and full test.

At 2021-01-25 16:21:33, "Jan Svoboda via Phabricator" <reviews@reviews.llvm.org> wrote:

jansvoboda11 raised a concern with this commit.
jansvoboda11 added a comment.

This commit seems to cause build failures across the board, e.g. http://lab.llvm.org:8011/#/builders/93/builds/1607

BRANCHES

main, master

Users:

benshi001 (Author)
jansvoboda11 (Auditor)

https://reviews.llvm.org/rG89a5147e5a0c

You can close this thread. :) Since I have reopen my original request https://reviews.llvm.org/D93579

jansvoboda11 accepted this commit.Jan 25 2021, 12:47 AM
All concerns with this commit have now been addressed.Jan 25 2021, 12:47 AM