HomePhabricator

DWARF: Fix a regression in location list dumping

Authored by labath on Sep 4 2019, 3:09 AM.

Description

DWARF: Fix a regression in location list dumping

Summary:
While fixing the handling of some error cases, r370363 introduced new
problems -- assertion failures due to unchecked errors (my excuse is that a very
early version of that patch used Optional<T> instead of Expected).

This patch adds proper handling of parsing errors encountered when
dumping location lists from inside DWARF DIEs, and adds a bunch of
additional tests.

I reorder the arguments of the location list dumping functions to make
them consistent, and also be able to dump the two kinds of location
lists generically.

Reviewers: JDevlieghere, dblaikie, probinson

Subscribers: aprantl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67102

llvm-svn: 370868

Details

Committed
labathSep 4 2019, 3:09 AM
Differential Revision
D67102: DWARF: Fix a regression in location list dumping
Parents
rGaae9972a3687: [cmake] Remove MSVC C4258 override
Branches
Unknown
Tags
Unknown