HomePhabricator

Fix race condition during process detach

Authored by labath on Sep 23 2015, 3:16 AM.

Description

Fix race condition during process detach

Summary:
The following situation occured in TestAttachResume:

The inferior was stoped at a breakpoint and we did a continue, immediately followed by a detach.
Since there was a trap instruction under the IP, the continue did a step-over-breakpoint before
resuming the inferior for real. In some cases, the detach command was executed between these two
events (after the step-over stop, but before continue). Here, public state was running, but
private state was stopped. This caused a problem because HaltForDestroyOrDetach was checking the
public state to see whether it needs to stop the process (call Halt()), but Halt() was checking
the private state and concluded that there is nothing for it to do.

Solution: Instead of Halt() call SendAsyncInterrupt(), which will then cause Halt() to be
executed in the context of the private state thread. I also rename HaltForDestroyOrDetach to
reflect it does not call halt directly.

Reviewers: jingham, clayborg

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D13056

llvm-svn: 248371

Details

Committed
labathSep 23 2015, 3:16 AM
Differential Revision
D13056: Fix race condition during process detach
Parents
rG64f68248cda5: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="
Branches
Unknown
Tags
Unknown