HomePhabricator

Do a better job at emitting prefrabricated skeleton CUs.

Authored by aprantl on Jul 26 2017, 11:48 AM.

Description

Do a better job at emitting prefrabricated skeleton CUs.

This is a better fix than r308708 for the problem introduced in
r304020. It restores the skeleton CU testcases modified by that commit
to their original form and most importantly ensures that
frontend-generated skeleton CUs (such as used to point to Clang
modules) come after the regular CUs. This broke for DICompileUnit
nodes that don't have any immediate children because they are now
constructed lazily instead of the order in which they are listed in
!llvm.dbg.cu. After this commit we still don't guarantee that order,
but we do guarantee that empty skeletons come last.

Shipping versions of LLDB are very sensitive to the ordering of
CUs. I'll track a fix for LLDB to be more permissive separately.
This fixes a test failure in the LLDB testsuite.

rdar://problem/33357252

llvm-svn: 309154

Details

Committed
aprantlJul 26 2017, 11:48 AM
Parents
rGa5e8dd35b00a: Simplify. NFC.
Branches
Unknown
Tags
Unknown