[lldb/ArchSpec] Always match simulator environment in IsEqualTo
Initially, Apple simulator binarie triples didn't use a -simulator
environment and were just differentiated based on the architecture.
For example, x86_64-apple-ios would obviously be a simualtor as iOS
doesn't run on x86_64. With Catalyst, we made the disctinction
explicit and today, all simulator triples (even the legacy ones) are
constructed with an environment. This is especially important on Apple
Silicon were the architecture is not different from the one of the
This change makes the simulator part of the environment always part of
the criteria to detect whether 2 ArchSpecs are equal or compatible.
Subscribers: inglorion, dexonsmith, lldb-commits
Differential Revision: https://reviews.llvm.org/D84716