HomePhabricator

[lldb/ArchSpec] Always match simulator environment in IsEqualTo

Authored by friss on Jul 27 2020, 5:05 PM.

Description

[lldb/ArchSpec] Always match simulator environment in IsEqualTo

Summary:
Initially, Apple simulator binarie triples didn't use a -simulator
environment and were just differentiated based on the architecture.
For example, x86_64-apple-ios would obviously be a simualtor as iOS
doesn't run on x86_64. With Catalyst, we made the disctinction
explicit and today, all simulator triples (even the legacy ones) are
constructed with an environment. This is especially important on Apple
Silicon were the architecture is not different from the one of the
simulated device.

This change makes the simulator part of the environment always part of
the criteria to detect whether 2 ArchSpecs are equal or compatible.

Reviewers: aprantl

Subscribers: inglorion, dexonsmith, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D84716

Details

Committed
frissJul 27 2020, 5:33 PM
Differential Revision
D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo
Parents
rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig
Branches
Unknown
Tags
Unknown