HomePhabricator

Combine multiple defs of arm64 register sets

Authored by omjavaid on Jul 7 2020, 8:24 AM.

Description

Combine multiple defs of arm64 register sets

Summary:
This patch aims to combine similar arm64 register set definitions defined in NativeRegisterContextLinux_arm64 and RegisterContextPOSIX_arm64.
I have implemented a register set interface out of RegisterInfoInterface class and moved arm64 register sets into RegisterInfosPOSIX_arm64 which is similar to Utility/RegisterContextLinux_* implemented by various other targets. This will help in managing register sets of new ARM64 architecture features in one place.

Built and tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabihf targets.

Reviewers: labath

Reviewed By: labath

Subscribers: mhorne, emaste, kristof.beyls, atanasyan, danielkiss, lldb-commits

Differential Revision: https://reviews.llvm.org/D80105

Details

Committed
omjavaidJul 7 2020, 8:25 AM
Reviewer
labath
Differential Revision
D80105: [LLDB] Combine multiple defs of arm64 register sets
Parents
rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver
Branches
Unknown
Tags
Unknown

Event Timeline

kwk added a subscriber: kwk.Jul 10 2020, 12:03 PM
kwk added inline comments.
/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
58

@omjavaid This broke s390x where this function is overridden but not const yet. I've addressed it here: https://reviews.llvm.org/D83580

omjavaid marked an inline comment as done.Jul 13 2020, 12:20 AM
omjavaid added inline comments.
/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
58

Thanks for taking care of this over the weekend.