HomePhabricator

[ORC] Use the new dispatchTask API to run query callbacks.

Authored by lhames on May 9 2021, 11:20 AM.

Description

[ORC] Use the new dispatchTask API to run query callbacks.

Dispatching query callbacks, rather than running them on the current thread,
will allow them to be distributed across multiple threads.

Details

Committed
lhamesMay 9 2021, 7:19 PM
Parents
rG5344c88dcb28: [ORC] Generalize materialization dispatch to task dispatch.
Branches
Unknown
Tags
Unknown

Event Timeline

Herald added a subscriber: Restricted Project. ยท View Herald TranscriptMay 9 2021, 7:38 PM
kuhnel added a subscriber: kuhnel.May 10 2021, 8:24 AM

I think this commit or the next one (7f9a89f9a2cc55dbfc315aa11416fe3609918199) broke the compilation of the examples. Can you please take a look?

examples/SpeculativeJIT/CMakeFiles/SpeculativeJIT.dir/SpeculativeJIT.cpp.o -c /mnt/disks/ssd0/agent/llvm-project/llvm/examples/SpeculativeJIT/SpeculativeJIT.cpp
/mnt/disks/ssd0/agent/llvm-project/llvm/examples/SpeculativeJIT/SpeculativeJIT.cpp:115:15: error: no member named 'setDispatchMaterialization' in 'llvm::orc::ExecutionSession'
    this->ES->setDispatchMaterialization(
    ~~~~~~~~  ^
1 error generated.

Full build log:
https://buildkite.com/llvm-project/llvm-main/builds/2505#77486285-8875-4d5f-86fe-3e9091bc13ec

Sorry, that seems to have been fixed already. I was looking at an old build.

2x sorry, that is actually still an open issue.

Sure thing. I should have a fix for this shortly.

  • Lang.